Skip to content

Conversation

@jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Dec 10, 2024

Dummy data fueling the deployed dashboard CI site now includes latest updates from worfklow.pacta.dashboard.

No corresponding issue.

@jdhoffa jdhoffa requested a review from MonikaFu as a code owner December 10, 2024 11:27
@jdhoffa jdhoffa requested a review from AlexAxthelm December 10, 2024 11:27
@github-actions
Copy link

github-actions bot commented Dec 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-10 12:04 UTC

@github-actions
Copy link

Docker build status

commit_time git_sha image
2024-12-10T11:27:16Z d82613a ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-153

Copy link
Contributor

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: You may want to run these json files through jq or similar, to keep the line breaks/indentation for human-readibility (probably a better optimization than minification right now)

@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 10, 2024

Non-blocking: You may want to run these json files through jq or similar, to keep the line breaks/indentation for human-readibility (probably a better optimization than minification right now)

I think the easiest/ most appropriate way to do that would be in the .prettierrc file.
However, I will tackle that one in a separate PR

@jdhoffa jdhoffa merged commit aff46f5 into main Dec 10, 2024
11 checks passed
@jdhoffa jdhoffa deleted the update_sample_data branch December 10, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants